Retry sending failed push notifications that were intended to be sent immediately #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings can be overridden via environment variables, following the guidelines outlined in https://12factor.net/config Fix pylint and mypi errors
Fix code style issue
There was a problem hiding this comment.
Github still shows commits from #2861 for some reason. Could you rebase this pr so that it only includes the relevant commits?
|
Code Climate has analyzed commit 1f59cb0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.9%. View more on Code Climate. |
|
Also, could you add a release note? :) |
Co-authored-by: David Venhoff <[email protected]>
deen13
requested review from
david-venhoff,
charludo,
JoeyStk,
lunars97 and
MizukiTemma
MizukiTemma
reviewed
Jul 17, 2024
MizukiTemma
approved these changes
Aug 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request modifies the push notification command to also collect all push notifications that were intended to be sent immediately but failed, as long as they are within the FCM_NOTIFICATION_RETAIN_TIME_IN_HOURS. The discussion regarding this behavior can be found here.
Proposed changes
send_push_notifications.pyPull Request Review Guidelines