-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include links of imprints into link replacement #2983
Include links of imprints into link replacement #2983
Conversation
Code Climate has analyzed commit 8e18bed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 83.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should we probaly think of centralised check for such process of adding/removing a model to/from our link features? Somthing like, listing models in one single list (as an environment variable, for exmaple) and we add a check whether all models of the list are included at the points where you need to add changes while removing/adding a model to the link check feature.
I think this is a good idea. For this case though I think it would be best to just completely rewrite the replace_links
function. Over time, it has become quite messy and now we have the get_region_links
function that we could use instead to make replace_links
both faster and cleaner.
Do you want to do that in this pr? Otherwise I could also do that in a follow-up pr.
@david-venhoff Thank you for review and idea 😸 I'd suggest to do it in another PR to stay in the policy "one PR, one purpose". |
1eeb11b
to
24a8537
Compare
Co-authored-by: David Venhoff <[email protected]>
24a8537
to
8e18bed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 😄
Short description
This PR adds
ImprintPageTranslation
into the target models ofreplace_links
so links in imprints can be replaced too by the "Search&Replace" on the uppr right corner of the broken link list.Proposed changes
ImprintPageTranslation
into the listmodels
in the functionreplace_links
Side effects
Resolved issues
Fixes: #2982
Pull Request Review Guidelines