Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appdev: static site builds #1230

Merged
merged 8 commits into from
Sep 15, 2022
Merged

appdev: static site builds #1230

merged 8 commits into from
Sep 15, 2022

Conversation

kamaln7
Copy link
Contributor

@kamaln7 kamaln7 commented Sep 14, 2022 •
edited
Loading

No description provided.

nicktate
nicktate approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@nicktate nicktate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, nice cleanup on the initial POC 🙇🏻 ; one small question in-line about the dockerfile-based asset path

internal/apps/builder/docker.go Show resolved Hide resolved
@kamaln7 kamaln7 merged commit 073f7e6 into digitalocean:feature/appdev Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktate nicktate nicktate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamaln7 @nicktate