support for windows docker-for-desktop #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcodybaker
approved these changes
Sep 20, 2022
|
|
jcodybaker
reviewed
Sep 20, 2022
internal/apps/builder/cnb.go
Outdated
| @@ -66,7 +66,7 @@ func (b *CNBComponentBuilder) Build(ctx context.Context) (res ComponentBuilderRe | |||
|
|
|||
| var sourceDockerSock string | |||
| switch runtime.GOOS { | |||
| case "darwin": | |||
| case "darwin", "windows": | |||
| // mac docker-for-desktop includes the raw socket in the VM | |||
There was a problem hiding this comment.
nit: might expand the comment to include windows
nicktate
force-pushed
the
ntate/appdev/windows-dfd
branch
from
1f10225
to
668b31f
Compare
kamaln7
approved these changes
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 20, 2022
nicktate
added a commit
to nicktate/doctl
that referenced
this pull request
Sep 21, 2022
andrewsomething
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Feature/appdev (#1204) * apps: add base scaffolding for app dev command subtree * charm templates: change up method signatures for easier use * only use 1.18.x in ci * add internal package to unit test * disable interactive mode * only use logging pager in interactive mode Co-authored-by: Kamal Nasser <[email protected]> * extract pager component and improve build log output * Add support for an app dev config and management (#1208) * Add support for build environment variables (#1209) * confirmation prompt component * text input component * Add support for build command overrides (#1211) * Add copy on write support for CNB builds (#1213) * confirm: display result options * split off list subpackage * split off pager subpackage * split off template and textbox packages * StyledText for icons * split off text component * improve indent util * confirm: clarify prompt persistance behavior * Add snap support for docker interface for app dev builds (#1214) * Add snap support for docker interface for app dev builds * add snap warning message * support cnb versioning, clean up build envs (#1215) * add support for local cnb caching (#1216) * add support for local cnb caching * address pr feedback * charm: improved output handling, add warning textbox variant * add config interfaces and types * use new config interfaces, add support for per-component config * address pr feedback, app dev workspace * structured config * unexport Config.AppID and config.AppSpecPath * unexport internal method * fix unclosed file handler in tests * test setting and unsetting component-level settings * appdev: handle user cancellation, log pager styling updates (#1229) * correctly handle user cancellation * log pager: update header/footer styling, scroll indicator * log pager: add title spinner * add support to build static site server image * add docker support for static builds * docker static site build cleanup * docker static site build tests * cnb static site build cleanup * cnb static site build tests * docker static site build input validation updates remove /var/run/docker.sock dependency from tests * fix path handling on windows * intercept ctrl-c to exit cleanly * Ntate/appdev/macossupport (#1235) * mount docker.sock.raw for mac docker-for-desktop * update local builder to v0.50.2 * support for windows docker-for-desktop (#1238) * appdev: pull required container images (#1240) * pull required container images * pull cnb stack run image * update no app spec error message * vendor latest godo * bump godo to v1.85.0 * support new godo interface types * address pr feedback * add better help messaging for app dev config Co-authored-by: Kamal Nasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this pull request accomplish