Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help texts taking into account multiple namespaces #1242

Merged

Conversation

joshuaauerbachwatson
Copy link
Contributor

In the run-up to doctl release 1.80 I neglected to amend the help text for doctl serverless connect to properly reflect what is now possible with multiple namespaces. Since this capability was hidden during the beta, the text did not get amended earlier.

In amending that text, I also touched on a few other help texts as I will note in comments.

@@ -36,7 +36,7 @@ to choose your sample language for `+"`"+`doctl serverless init`+"`"+`.`,
AddStringFlag(create, "language", "l", "javascript", "Language for the initial sample code")
AddBoolFlag(create, "overwrite", "", false, "Clears and reuses an existing directory")

deploy := CmdBuilder(cmd, RunServerlessExtraDeploy, "deploy <directories>", "Deploy a functions project to your functions namespace",
deploy := CmdBuilder(cmd, RunServerlessExtraDeploy, "deploy <directory>", "Deploy a functions project to your functions namespace",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An unrelated fix. Only one project (directory) can be deployed at a time so the original text was misleading.

One or more local file system areas are employed, along with a 'functions namespace' in the cloud.
Short: "Develop, test, and deploy serverless functions",
Long: `The ` + "`" + `doctl serverless` + "`" + ` commands provide an environment for developing, testing, and deploying serverless functions.
One or more local file system areas are employed, along with one or more 'functions namespaces' in the cloud.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to mentioning multiple namespaces here, the language suggesting that doctl serverless can only be used for testing and not final deployment is relaxed, since we do now support using the result of doctl serverless deploy in production.

@danaelhe danaelhe merged commit ff53e5e into digitalocean:main Sep 21, 2022
@joshuaauerbachwatson joshuaauerbachwatson deleted the better-connect-help branch September 26, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants