appdev: update flag documentation, scope timeout flag to actual build #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktate
approved these changes
Sep 25, 2022
andrewsomething
approved these changes
Sep 26, 2022
rcj4747
reviewed
Sep 26, 2022
| ) | ||
|
|
||
| AddDurationFlag( | ||
| build, doctl.ArgTimeout, | ||
| "", 0, | ||
| "An optional timeout duration for the build", | ||
| `An optional timeout duration for the build. Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". Example: 15m30s`, |
There was a problem hiding this comment.
You could probably drop the small time values, they seem impractical, to make this more concise and reduce clutter.
Suggested change
| `An optional timeout duration for the build. Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". Example: 15m30s`, | |
| `An optional timeout duration for the build. Valid time units are "s", "m", "h". Example: 15m30s`, |
| ) | ||
|
|
||
| AddStringFlag( | ||
| build, doctl.ArgRegistry, | ||
| "", os.Getenv("APP_DEV_REGISTRY"), | ||
| "Registry name to build use for the component build.", | ||
| "An optional registry name to tag built container images with.", |
There was a problem hiding this comment.
Here's a suggestion in case ending a sentence with a preposition concerns people. :-)
Suggested change
| "An optional registry name to tag built container images with.", | |
| "An optional registry name used to tag built container images.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.