-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-writes activations list command subtree in Go #1277
Re-writes activations list command subtree in Go #1277
Conversation
@ddebarros I am seeing commits in this PR that were already merged in the earlier PR. Did this get properly rebased? |
7456d3b
to
f3e3ebd
Compare
I rebased it again. Should be all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job so far @ddebarros . I left some comments which should probably be addressed but I think the main issue at this point is that the tests don't pass yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this PR includes a change to a vendor-supplied package. I would think we should not be doing that (certainly not lightly). I misunderstood in earlier conversations. I think we need to understand why this change is necessary and can the goal be accomplished differently.
@joshuaauerbachwatson I created a PR on the openwhisk-client and updated our go.mod file to reflect this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. I approve.
Over to @andrewsomething for permission to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A did have a few tiny nitpicks inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
This PR re-write the
doctl sls activations list
subtree in native go-lang. All existing behavior is maintained.