Add support for retrying failed requests. #1405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for retrying failed requests. A few things to note:
http-retry-max
flag to users to give them insight into the new default behavior. I've marked thehttp-retry-wait-max
andhttp-retry-wait-min
flags as hidden as the defaults should be fine for most users, but it still allows for configuration if needed.int
rather than afloat64
as I feel that it is friendlier on the command line.http
prefix on these so that the environment variables end up consistent with the same settings ion Terraform, e.g.DIGITALOCEAN_HTTP_RETRY_MAX
.doctl account ratelimit
command. The purpose of the command is to return the rate-limit headers regardless of response status. So retrying here just hides the current status and delays returning a response for no real gain.