Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s: Update Node Pool documentation #1517

Merged
merged 5 commits into from
Apr 1, 2024
Merged

K8s: Update Node Pool documentation #1517

merged 5 commits into from
Apr 1, 2024

Conversation

danaelhe
Copy link
Member

Addressing #1516

Adding explicit documentation that minimum node pool size can't not be zero if autoscale is true.

Addressing #1516

Adding explicit documentation that minimum node pool size can't not be zero if autoscale is true.
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #1516, they're referencing the node-pool create sub-command. That's where the default of 0 is specified in the docs.

AddIntFlag(cmdKubeNodePoolCreate, doctl.ArgNodePoolMinNodes, "", 0,

So we probably want to update there as well.

@danaelhe
Copy link
Member Author

Looking at #1516, they're referencing the node-pool create sub-command. That's where the default of 0 is specified in the docs.

AddIntFlag(cmdKubeNodePoolCreate, doctl.ArgNodePoolMinNodes, "", 0,

So we probably want to update there as well.

good catch 👍

@danaelhe danaelhe merged commit 8edfc44 into main Apr 1, 2024
7 checks passed
@danaelhe danaelhe deleted the k8s_doc branch April 1, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants