Update for Elm 0.19 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtian
force-pushed
the
[email protected]
branch
3 times, most recently
from
2517094
to
ba1f68e
Compare
|
@xtian thank you so much for the PR! That's awesome that you did this! I am also going to rename the package to |
xtian
commented
May 24, 2018
package.json
Outdated
| "elm-live": "^2.7.5", | ||
| "elm-webpack-loader": "^4.3.1", | ||
| "elm-test": "^0.18.12", | ||
| "elm-webpack-loader": "git+ssh://[email protected]/xtian/elm-webpack-loader.git#0.19", |
There was a problem hiding this comment.
dillonkearns
force-pushed
the
master
branch
2 times, most recently
from
0241578
to
a3f5d0c
Compare
xtian
force-pushed
the
[email protected]
branch
3 times, most recently
from
f103928
to
6608903
Compare
|
@dillonkearns Got everything compiling, but there are test failures now. I can dig into them in a little bit. |
xtian
force-pushed
the
[email protected]
branch
6 times, most recently
from
0205a17
to
f099709
Compare
xtian
force-pushed
the
[email protected]
branch
7 times, most recently
from
1ef0a00
to
02f61a4
Compare
xtian
force-pushed
the
[email protected]
branch
from
ea8bf97
to
a81f0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elm-community packages aren't updated for 0.19 yet, so I wasn't able to resolve all the compiler errors (and since I couldn't compile, I wasn't able to build the generated code), but I made as much progress as I could. Hope this is useful! :)