Fixes a bug causing Updates to get stale #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internally by update helper
3 tasks
avazirna
reviewed
Sep 17, 2024
| // skip if - An update task is already running | no app is seated | user session is not active | ||
| if (UpdateTask.getRunningInstance() == null && | ||
| CommCareApplication.instance().currentApp != null && | ||
| CommCareApplication.instance().session.isActive) { |
There was a problem hiding this comment.
just a clarification, in the previous version, in case there was no active user session the result would be success, so what was causing the errors when there was no active session?
There was a problem hiding this comment.
the call to CommCareApplication.instance().session.isActive would itself error out with a SessionUnavailableException
avazirna
approved these changes
Sep 18, 2024
|
@damagatchi retest this please |
|
Only test failure was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://dimagi.atlassian.net/browse/SC-3923
Bug Fix for App updates.
Background updates were failing due to SessionNotAvailable exception due to us unneccesarily checking for user session being active in the Update Worker. This PR makes 2 important changes to eliminate this -
Safety Assurance
Automated test coverage
Covered in UpdateWorkerTests
Safety story
Mostly relying on tests coverage here plus the change not affecting any functional update code.
cross-request: dimagi/commcare-core#1438