Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused cipher pool #2865

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unused cipher pool #2865

wants to merge 2 commits into from

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Sep 23, 2024 •
edited
Loading

Summary

Removes unused cipher pool classes

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Safety story

Integration Tests should be enough testing on this.

@shubham1g5 shubham1g5 marked this pull request as ready for review October 1, 2024 07:56
@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Oct 1, 2024
@shubham1g5
Copy link
Contributor Author

All tests passed except the DateWidgetTests which is unrelated, running the build without integration tests.
@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avazirna avazirna Awaiting requested review from avazirna

@OrangeAndGreen OrangeAndGreen Awaiting requested review from OrangeAndGreen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-integration-tests Skip android tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shubham1g5