Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/select text detail #1396

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Rc/select text detail #1396

merged 3 commits into from
Jan 22, 2024

Conversation

Robert-Costello
Copy link
Contributor

Product Description

Technical Summary

Jira ticket: https://dimagi-dev.atlassian.net/browse/USH-3859

utilized in dimagi/formplayer#1529

Safety Assurance

Safety story

tested locally and will test on staging

Automated test coverage

QA Plan

no QA planned

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

Copy link
Contributor

@Jtang-1 Jtang-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just a nit, but adding docstring for getSelectText would be nice

@Robert-Costello
Copy link
Contributor Author

duplicate this PR

@Robert-Costello Robert-Costello merged commit 25298d3 into formplayer Jan 22, 2024
2 checks passed
@shubham1g5
Copy link
Contributor

@Robert-Costello Can we update the suite wiki with this model change as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants