Small fix for Stack frame extras #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
snopoke
reviewed
May 2, 2024
|
Confirming, I don't see frame step extras being used for any steps other than query or smart link. |
snopoke
approved these changes
May 3, 2024
|
duplicate this PR ad23db8 |
|
duplicate this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Changes frame extras from a multi-map of
String,ListOf(Object)toString, Object. I think it was an oversight that we were handling map values as a listOf(Object) which with multi-map was causing value to be a listOf(ListOf(Object)) for a given key.This causes a big confusion today when handling these extras as there are other places where we handle this datastructure correctly (i.e use
putAllas in this PR on multi-map)Safety Assurance
Change radius is limited to smart links with query steps (inline case search). This have good test coverage on FP side.
QA Plan
None
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.