Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mobile UCR Versions for Domains (Script) #35158

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions corehq/mobile_ucr_v2_update_script.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# This script updates the latest versions of all apps across domains that are using v1 with no manual references
# Steps followed
# 1. Get All domains with mobile ucr flag enabled
# 2. Get all apps for domain with latest released versions and mobile ucr versions that are not v2
# 3. For each app, if it contains no V1 UCR references, update the version to 2

# How to run
# Can be run in django shell. Paste the script and execute the function process()
# File is stored in home directory of cchq user.

# V1 Examples
# https://staging.commcarehq.org/a/test-commcare-superset/apps/view/f940fcc83bae44b8a0adaf719673fd1e/form/a0f3c5b483c645e78b6f89ee0b3b3c03/source/#form/table_child_count


import json
import re
import traceback

from corehq.apps.app_manager.dbaccessors import (
get_latest_app_ids_and_versions,
get_apps_by_id,
)
from corehq.apps.app_manager.const import MOBILE_UCR_VERSION_2
from corehq.toggles import MOBILE_UCR
from corehq.toggles.shortcuts import find_domains_with_toggle_enabled
from corehq.util.log import with_progress_bar


def save_in_log(file, data):
print(data)
file.write(data + '\n')


def save_as_ndjson(path, data):
with open(path, 'a') as file:
print(json.dumps(data, separators=(',', ':')), file=file)


def read_ndjson_file(path):
with open(path, 'r') as file:
return [json.loads(line) for line in file.readlines()]


def has_non_v2_form(domain, app, log_file):
for form in app.get_forms():
save_in_log(log_file, f"Processing Form: {domain}: {form.name}")
# The second condition should always be False if the first one is
# but just as a precaution we check for it
if V1_FIXTURE_IDENTIFIER in form.source or re.findall(V1_ALL_REFERENCES, form.source):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findall() will return all matches, but we don't really care about all the matches, we just what to know whether any exist. If you use search() instead then it will stop searching as soon as it's found the first match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this sounds like the better approach. Addressed in 0392d0f.

save_in_log(log_file, f"App Contains V1 Refs: {domain}: {app.name}")
return True
return False


def update_app(domain, app, log_file):
save_in_log(log_file, f"Updating App: {domain}: {app.name}: {app.id}")
app.mobile_ucr_restore_version = MOBILE_UCR_VERSION_2
app.save()


PROCESSED_DOMAINS_PATH = '/home/zandre/cchq/updated_domains.ndjson'
LOG_FILE = '/home/zandre/cchq/update_to_v2_ucr_script.log'

V1_FIXTURE_IDENTIFIER = 'src="jr://fixture/commcare:reports'
V1_FIXTURE_PATTERN = r'<.*src="jr://fixture/commcare:reports.*>'
V1_REFERENCES_PATTERN = r"<.*instance\('reports'\)/reports/.*>"
V1_ALL_REFERENCES = f"{V1_FIXTURE_PATTERN}|{V1_REFERENCES_PATTERN}"
Copy link
Contributor

@kaapstorm kaapstorm Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you're using this pattern multiple times, I'd compile it.

... using re.compile() and saving the resulting regular expression object for reuse is more efficient when the expression will be used several times in a single program.
-- https://docs.python.org/3/library/re.html#re.compile

Suggested change
V1_ALL_REFERENCES = f"{V1_FIXTURE_PATTERN}|{V1_REFERENCES_PATTERN}"
RE_V1_ALL_REFERENCES = re.compile(f"{V1_FIXTURE_PATTERN}|{V1_REFERENCES_PATTERN}")

You can then use findall() or search() as a method:

RE_V1_ALL_REFERENCES.search(form.source)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful to know, thanks! Addressed in 0392d0f.



skip_domains = []


def process():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the flow of code in the file made it a bit hard to follow along. Just reminding on keeping things in a file in logical order. I am big fan on vertical formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this might be difficult with all the helper functions at the top. I've refactored this to have the main process function at the top instead eac2bcf.

try:
processed_domains = read_ndjson_file(PROCESSED_DOMAINS_PATH)
except FileNotFoundError:
processed_domains = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Better to use a set: If you're checking for membership of a group, a set will be O(1) but a list will be O(n). This applies to skip_domains too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. Addressed in b3e4252.


mobile_ucr_domains = find_domains_with_toggle_enabled(MOBILE_UCR)

log_file = open(LOG_FILE, 'a')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would leave the connection to the file open even after the script exits abruptly, so we should this with with option. This way you also don't need to worry about explicitly calling close.
with open(LOG_FILE, 'a') as log_file:

Does mode 'a' create the file if its missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the code, I can remove the need for passing the log file around to the various helper functions. Since we already know what the file path is, we can just use this directly in the helper function for adding to the log. Addressed in 27c1c25.

Does mode 'a' create the file if its missing?

It does. Here is an article for more info on the append mode.


save_in_log(log_file, f"Number of domains with mobile ucr flag enabled: {len(mobile_ucr_domains)} ")

for domain in with_progress_bar(mobile_ucr_domains):
if domain in processed_domains:
save_in_log(log_file, f"Already processed domain: {domain}")
continue
if domain in skip_domains:
save_in_log(log_file, f"Skipped domain: {domain}")
continue

save_in_log(log_file, f"Processing domain: {domain} ...")
app_ids = list(get_latest_app_ids_and_versions(domain))
apps = get_apps_by_id(domain, app_ids)
for app in apps:
try:
# Don't look at app.is_released since the latest version might not be released yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that we are just picking app and not releases.
I believe one way to confirm that is by checking copy_of property on the application. Is it blank for applications and not blank for releases. it would be a good check to have though I assume you are anyway only picking up applications and not releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that we are just picking app and not releases.

Could you please elaborate on what you mean by app vs release? Are you referring to app versions that have been marked as "Released" or are you referring to the app versions themselves?

This comment refers that we are picking the latest version of each app and we don't want to consider app.is_released since the latest version of an app might still be set to "Test" and not "Released"

if app.mobile_ucr_restore_version != '2.0':
save_in_log(log_file, f"Processing App: {domain}: {app.name}: {app.id}")
if not has_non_v2_form(domain, app, log_file):
update_app(domain, app, log_file)
else:
save_in_log(
log_file,
f"App contains V1 references and couldn't updated: {domain}: {app.name}: {app.id}",
)
except Exception as e:
save_in_log(log_file, f"Error occurred for {domain}: {str(e)}")
save_in_log(log_file, traceback.format_exc())
continue
save_as_ndjson(PROCESSED_DOMAINS_PATH, domain)

log_file.close()
Loading