Retry 400 "Bad Request" responses #35165
Merged
+96
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gherceg
approved these changes
Oct 3, 2024
Comment on lines
400
to
410
| @contextmanager | ||
| def repeat_record(self): | ||
| repeat_record = self.repeater.repeat_records.create( | ||
| domain=DOMAIN, | ||
| payload_id='eggs', | ||
| registered_at=timezone.now(), | ||
| ) | ||
| try: | ||
| yield repeat_record | ||
| finally: | ||
| repeat_record.delete() |
There was a problem hiding this comment.
We don't actually have to handle cleanup for a SQL Table in a TestCase class since all SQL updates happen within a transaction that is rolled back at the end of the test right? Could this be simplified to not use a context manager or is there a benefit to this I'm missing?
There was a problem hiding this comment.
It could totally just create the repeat record. I'll change it.
|
The failing test looks related |
gherceg
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Context: SAAS-15905 discussion
Currently when Data Forwarding gets a 400 "Bad Request" response, it handles the repeat record as an invalid payload.
However, when Data Forwarding forwards a case update for a case that has not yet been created, CommCare's Configurable API returns a 400 "Bad Request" response, and we want that repeat record to be retried, so that the next attempt might be after the case has been created.
This change is to retry 400 "Bad Request" responses. It feels arguably justifiable that the 400 error code is broad enough to include situations where one might want to retry the request.
Safety Assurance
Safety story
Automated test coverage
Includes tests
Rollback instructions
Labels & Review