-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render generated images inline with the message #706
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: apps/utils/markdown.py
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
This makes it more universal and also updates the code to include the file extension in the Django file which is used when downloading the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite cool, thanks. Do you think we should make the image a bit smaller? Not sure how easy that would be.
Perhaps but I'm considering this out of scope for now. We could potentially implement it using markdown without resizing the image itself: https://stackoverflow.com/a/21242579 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Description
This updates the message processing and rendering to insert generated images as inline image links into the output markdown.
The markdown rendered will then render them as images.
Also fix for DIMAGI-BOTS-FA
User Impact
Images are displayed in the message. This only applies to web chat when using Assistants to generate images.
Demo
Docs
NA