Make safety layer tags red #707
Open
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
snopoke
reviewed
Oct 4, 2024
apps/annotations/models.py
Outdated
| for tag in self.tags.all(): | ||
| bage_color = "badge-neutral" | ||
| if tag.is_system_tag: | ||
| bage_color = "badge-error" if tag.category == TagCategories.SAFETY_LAYER_RESPONSE else "badge-warning" |
There was a problem hiding this comment.
It can be dangerous to use css classes in Python since the post processor will remove classes that aren't used and it doesn't currently check python files for usages.
What about doing this logic in the template and just using 'tags_json' instead of this method? I think we could get rid of this method entirely if we did that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Red safety layer violation tags
User Impact
N/A
Demo
Docs
N/A