Fix numerical issue on SVD with near-identity matrix #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vollkornaffe
force-pushed
the
fix_svd_for_small_valued_matrix
branch
2 times, most recently
from
5bcbce6
to
dd44414
Compare
sebcrozet
approved these changes
Mar 28, 2024
The column may not be normalized if the `factor` is on a scale of 1e-40. Possibly, f32 just runs out of precision. There is likely a better solution to the problem.
sebcrozet
force-pushed
the
fix_svd_for_small_valued_matrix
branch
from
440d4a4
to
4dad6b3
Compare
sebcrozet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column may not be normalized if the
factoris on a scale of 1e-40.Possibly,
f32just runs out of precision.There is likely a better solution to the problem.
Fixes #1368