Fix #1608: Overlapped Div Gets Clicked When Closing Pswp From UI Toolbar #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing photoswipe too fast causes, overlapping div gets clicked! To prevent this added 10 ms delay before closing pswp.
|
It should be enough to use timeout without 10ms delay |
Removed 10ms delay. setTimeout is enough.
|
@ast-osoloviov You are right, setTimeout is enough. Removed 10ms delay. |
ast-osoloviov
approved these changes
Oct 29, 2019
|
Fixed by v5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing photoswipe too fast causes overlapped div gets clicked! To prevent this added 10 ms delay before closing pswp.
Fixes: #1608