Add ability to retry Graphql requests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
requested changes
Jul 9, 2023
Co-authored-by: Rijk van Zanten <[email protected]>
rijkvanzanten
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we are doing a build, we expect that to be successful.
Although in some cases, we may have momentary network issues or even the project not being able to respond in expected.
Solution
To overcome this scenarios, this PR introduces the concept of retries.
It is configured with 5 retries that are delayed between 1 and 8 seconds.
This was inspired on
gatsby-source-graphqlimplementation since we are already using it, so we can just includenode-fetchas peer dependency (correct me if I am wrong).PS: Not sure why there's many changes on
pnpm-lock.yamlbut probably because of pnpm version. I am using 8.6.2