introduce new value to enable env configuration #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcules
force-pushed
the
feature/make-deployment-env-configurable
branch
from
1f20294
to
f471b37
Compare
|
Thank you very much! This just came in time to allow a custom fix for louislam/uptime-kuma#1141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Generally allow the user to configure environment variables for the deployment manifest / pod definition. This can be used to add custom environment variables through values.yaml and in particular can be used to override the UPTIME_KUMA_PORT env var until the PR louislam/uptime-kuma#1141 is merged.
Benefits
Make this helm chart more configurable and provide a working workaround for the aforementioned issue.
Possible drawbacks
None.
Applicable issues
n/a
Additional information
n/a
Checklist
Chart.yamlaccording to semver.