Implement X-RateLimit-Precision handling #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
type: enhancement
status: freezer
jhgg
reviewed
Aug 11, 2019
|
Waiting for this to be deployed so reactions don't send at lower rates. |
|
We should expect users to have a proper ntp synchronized clock on their system. |
|
Cloned the repo with this branch and it gives me instant NPE while starting the bot on the line 156 (parseDouble). Will add more details later tomorrow. |
|
I'd guess that's because the particular headers are only in planning right now and are not in production? |
|
Ooh I see. I'm dumb, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This implements the upcoming
X-RateLimit-Precisionheader. Unfortunately discord doesn't echo this header so we have to wait for it to be released.