Add an upper limit to prune and retrievePrunableMemberCount #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuildImpl#retrievePrunableMemberCount will now throw if `days` is above 30.
Documentation of Guild#prune and Guild#retrievePrunableMemberCount now specifies the upper limit of the `days` argument.
markozajc
changed the title
|
Switched to hacktoberfest base as this is not urgent enough to trigger a new build right away |
MinnDevelopment
approved these changes
Oct 25, 2019
kantenkugel
approved these changes
Oct 26, 2019
MinnDevelopment
added a commit
that referenced
this pull request
Nov 13, 2019
* Add an upper limit to prune and retrievePrunableMemberCount (#1118) * Create constant for max slowmode (#1108) * Improve documentation for reaction pagination * Updated outdated javadoc comments * Add some documentation * Fix description of ChannelAction.setBitrate * Update bitrate docs on ChannelManager * Fix single typo * Fix "Malformed HTML" javadoc task compilation error * Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Adds an upper limit to Guild#prune's and Guild#retrievePrunableMemberCount's
daysaccording to Discord API's upper limit of thirty days. This prevents illegal amounts causing 400s by checking if the upper limit is met and throwing if it's not before a REST request can be made.