Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote commons-collections4 to an API dependency (#1120) #1121

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Promote commons-collections4 to an API dependency (#1120) #1121

merged 1 commit into from
Oct 9, 2019

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Oct 9, 2019 •
edited by MinnDevelopment
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #1120

Description

Promotes the commons-collections4 dependency to API scope to properly provide bags in the message interface.

@MinnDevelopment MinnDevelopment changed the base branch from master to development October 9, 2019 08:13
@MinnDevelopment
Copy link
Member

Refer to Contributing Guidelines please base your changes on development.

@Vampire
Copy link
Contributor Author

Vampire commented Oct 9, 2019

rebase is pushed, sorry

@MinnDevelopment MinnDevelopment merged commit 34ad428 into discord-jda:development Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vampire @MinnDevelopment