Implement Role#getTags and add CacheFlag#ROLE_TAGS #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
This feature hasn't been fully deployed yet and is not yet documented. I will keep this on freezer in the meantime. |
|
If needed could I make a PR targeting this branch, to implement comments. |
|
Feel free to add me as reviewer once its ready to be merged. BTW: the last 2 changed files don't seem to be related to the tags at all. Do you want to implement them in some different branch, if not already planned? |
# Conflicts: # src/main/java/net/dv8tion/jda/internal/handle/GuildMemberRemoveHandler.java
Andre601
reviewed
Aug 5, 2020
MinnDevelopment
commented
Aug 9, 2020
# Conflicts: # src/main/java/net/dv8tion/jda/internal/entities/RoleImpl.java
MinnDevelopment
added
size: small
type: feature
and removed
status: freezer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This introduces the new tags for roles which can be used to identify which role is used for boosters or the bot.