Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change checks for emote name length to check minimum length #1701

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Change checks for emote name length to check minimum length #1701

merged 4 commits into from
Jul 2, 2021

Conversation

LenderSchlender
Copy link
Contributor

@LenderSchlender LenderSchlender commented Jul 1, 2021 •
edited
Loading

Add Checks#notShorter(), and check for the name length when creating/updating emotes.

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This PR adds a Checks#notShorter() method, and adds checks for the name length when creating/updating emotes.

@LenderSchlender LenderSchlender changed the title Add Checks#notShorter(), and check for the name length when creating/… Add Checks#notShorter(), and check for the emote name length Jul 1, 2021
Remove Checks#notShorter() again, add Checks#inRange instead and remo…
3a99301 
…ve an unneeded check in GuildImpl#createEmote()
@MinnDevelopment MinnDevelopment changed the title Add Checks#notShorter(), and check for the emote name length Change checks for emote name length to check minimum length Jul 2, 2021
@MinnDevelopment MinnDevelopment merged commit 05b7755 into discord-jda:development Jul 2, 2021
Tais993 pushed a commit to Tais993/JDA that referenced this pull request Sep 13, 2021
@LenderSchlender @Tais993
Change checks for emote name length to check minimum length (discord-…
beea8ab 
…jda#1701)
This was referenced Jan 8, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre601 Andre601 Andre601 left review comments

@MinnDevelopment MinnDevelopment MinnDevelopment left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LenderSchlender @Andre601 @MinnDevelopment