Bump embed max description length #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chew
reviewed
Jul 2, 2021
Also change FOOTER_MAX_LENGTH to TEXT_MAX_LENGTH
MinnDevelopment
approved these changes
Jul 4, 2021
Tais993
pushed a commit
to Tais993/JDA
that referenced
this pull request
Sep 13, 2021
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: #1702
Description
Increases the
MessageEmbed.TEXT_MAX_LENGTHto4096and also adds new value calledFOOTER_MAX_LENGTHsince the old Javadoc mentions the text value being for description AND footer.Not sure if a new value shouldn't be added for the description while deprecating the text one for those who are using this int value for both footer and description...