-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Markdown escape all #1754
Merged
DV8FromTheWorld
merged 7 commits into
discord-jda:development
from
sofiadparamo:markdown-escape-all
Oct 20, 2021
Merged
Feature: Markdown escape all #1754
DV8FromTheWorld
merged 7 commits into
discord-jda:development
from
sofiadparamo:markdown-escape-all
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
requested changes
Sep 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, here is my review
Bump |
You need to fix your commit history, you added commits from other PRs. |
sofiadparamo
force-pushed
the
markdown-escape-all
branch
from
September 23, 2021 18:12
5d2df37
to
da3ddd8
Compare
Co-authored-by: Florian Spieß <[email protected]>
MinnDevelopment
approved these changes
Sep 23, 2021
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: #1298
Description
Added method to escape all markdown tokens in a given String, without checking for region ends, ignoring already escaped characters.
This pull request also contains tests for the described method.