Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Markdown escape all #1754

Merged

Conversation

sofiadparamo
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #1298

Description

Added method to escape all markdown tokens in a given String, without checking for region ends, ignoring already escaped characters.

This pull request also contains tests for the described method.

@sofiadparamo sofiadparamo changed the title Markdown escape all Feature: Markdown escape all Aug 2, 2021
@sofiadparamo sofiadparamo marked this pull request as draft August 2, 2021 16:17
@sofiadparamo sofiadparamo marked this pull request as ready for review August 3, 2021 04:29
Copy link
Member

@MinnDevelopment MinnDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, here is my review

src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
src/test/java/MarkdownTest.java Show resolved Hide resolved
src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
src/test/java/MarkdownTest.java Outdated Show resolved Hide resolved
@DV8FromTheWorld
Copy link
Member

Bump

@MinnDevelopment
Copy link
Member

You need to fix your commit history, you added commits from other PRs.

@sofiadparamo sofiadparamo reopened this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants