Change choice name length check to 100 instead of 32 #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexillium1
changed the title
src/main/java/net/dv8tion/jda/api/interactions/commands/build/OptionData.java
Outdated
Show resolved
Hide resolved
A commit that moved many constants to the MAX_NAME_LENGTH mistakenly also moved a few values that were 100 into a constant with value 25. This commit will add a new constant, MAX_NAME_OPTION_LENGTH, to fix those values back to their intended values of 100.
MinnDevelopment
approved these changes
Sep 2, 2021
MinnDevelopment
changed the title
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
A commit that moved many constants to the MAX_NAME_LENGTH mistakenly also moved a few values that were 100 into a constant with value 32.
This commit will add a new constant, MAX_NAME_OPTION_LENGTH, to fix those values back to their intended values of 100.
The commit title is meant to say Option Choice, not OptionData.