Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed MessageCreateBuilder#fromEdit() to fromEditData #2225

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Renamed MessageCreateBuilder#fromEdit() to fromEditData #2225

merged 1 commit into from
Aug 28, 2022

Conversation

lilmayu
Copy link
Contributor

@lilmayu lilmayu commented Aug 27, 2022

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2224

Description

Renames MessageCreateBuilder#fromEdit() to MessageCreateBuilder#fromEditData() for consistent naming between MessageCreateBuilder and MessageEditBuilder.

@MinnDevelopment MinnDevelopment added the type: breaking contains a backwards incompatible change label Aug 28, 2022
@MinnDevelopment MinnDevelopment merged commit c2b439e into discord-jda:master Aug 28, 2022
@lilmayu lilmayu mentioned this pull request Aug 28, 2022
Closed
3 tasks
@lilmayu lilmayu deleted the fix/fromEditRename branch August 28, 2022 17:29
@lilmayu lilmayu restored the fix/fromEditRename branch August 28, 2022 17:29
@renovate renovate bot mentioned this pull request Aug 8, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: breaking contains a backwards incompatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilmayu @MinnDevelopment