Properly handle MANAGE_THREAD permission for managing threads #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
approved these changes
Sep 11, 2022
DV8FromTheWorld
force-pushed
the
bug/thread-manage-perms
branch
from
d0151eb
to
c7d55b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: #2188
Replaces PR: #2190
Description
When calling
ThreadChannel#getManagerorThreadChannel#deleteit is currently checked if the user has theMANAGE_CHANNELpermission, but the permission actually required to manage or delete a thread isMANAGE_THREADS.Additionally, when the bot owns the thread, it doesn't matter whether they have
MANAGE_THREADSor not.