Upgrade to voice gateway v8 #2717
Merged
+470
−3,596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Aug 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | maven | stage | patch | `3.9.8-amazoncorretto-21` -> `3.9.9-amazoncorretto-21` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [net.dv8tion:JDA](https://togithub.com/discord-jda/JDA) | compile | minor | `5.0.2` -> `5.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | parent | patch | `3.3.2` -> `3.3.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>discord-jda/JDA (net.dv8tion:JDA)</summary> ### [`v5.1.0`](https://togithub.com/discord-jda/JDA/releases/tag/v5.1.0): | Voice Gateway v8 ### Overview This release updates the implementation of the voice gateway to API version 8 (previously 4). Previous versions will be incompatible coming November 18, 2024. This includes adding a new dependency on [tink](https://togithub.com/tink-crypto/tink-java), to support the new encryption modes. Additionally, the `MessageEmbedEvent` has been removed. Discord sends standard update events for embed loading now, this event can no longer be supported. #### New Features - Add new message and embed types by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2716](https://togithub.com/discord-jda/JDA/pull/2716) #### Changes - Upgrade to voice gateway v8 by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2717](https://togithub.com/discord-jda/JDA/pull/2717) - Remove MessageEmbedEvent by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2720](https://togithub.com/discord-jda/JDA/pull/2720) #### Bug Fixes - Handle guild stickers array as optional in EntityBuilder#createGuild by [@​Xirado](https://togithub.com/Xirado) in [https://github.com/discord-jda/JDA/pull/2714](https://togithub.com/discord-jda/JDA/pull/2714) **Full Changelog**: discord-jda/JDA@v5.0.2...v5.1.0 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.1.0") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.1.0</version> </dependency> ``` </details> <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.3.3`](https://togithub.com/spring-projects/spring-boot/compare/v3.3.2...v3.3.3) [Compare Source](https://togithub.com/spring-projects/spring-boot/compare/v3.3.2...v3.3.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on saturday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
](https://renovatebot.com){kind=link}
|
Hello! I attempted to upgrade from version 5.0.2 to 5.1.0 today, but it caused an issue with receiving voice audio. The audio is either not coming at all or is just silence frames - I'm not sure on that one, further investigation is needed. My AudioReceiveHandler impl: https://pastebin.com/kxXUW2qG |
|
Hello, the issue with voice receive has been fixed in a followup MR that hasn't made it into a new release yet. Please use the older version until then, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Upgrades our voice gateway logic to v8.
Reference: discord/discord-api-docs#7075
TODO: Support new encryption modes