Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GuildVoiceUpdateEvent to combine leave and move #559

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

MinnDevelopment
Copy link
Member

Pull Request Etiquette

There are several guidelines you should follow in order for your
Pull Request to be merged.

It is sometimes better to include more changes in a single commit.
If you find yourself having an overwhelming amount of commits, you
can rebase your branch.

Template

Pull Request

Allows to do:

public class MyListener extends ListenerAdapter {
    @Override
    public void onGuildVoiceUpdate(GuildVoiceUpdateEvent event) {
        // do stuff when user leaves channel
    }
}

instead of:

public class MyListener extends ListenerAdapter {
    @Override
    public void onGuildVoiceLeave(GuildVoiceLeaveEvent event) {
        onGuildVoiceUpdate(event.getChannelLeft());
    }
    @Override
    public void onGuildVoiceMove(GuildVoiceMoveEvent event) {
        onGuildVoiceUpdate(event.getChannelLeft());
    }

    public void onGuildVoiceUpdate(VoiceChannel oldChannel) {
        // do stuff when user leaves channel
    }
}

Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*.java text eol=crlf
*.gradle text eol=crlf

* text=auto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually change? Why'd you set it?

Copy link
Member Author

@MinnDevelopment MinnDevelopment Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On linux git wants to replace the crlf with lf on all files so I had to set it, this also prevents git from sending .java/.gradle files with other line endings. the * text=auto is the default for git to choose the best line ending it sees fit if no other rule overweights it

@MinnDevelopment MinnDevelopment added this to the Release 3.4 milestone Dec 9, 2017
@MinnDevelopment MinnDevelopment changed the base branch from master to development December 10, 2017 13:36
@MinnDevelopment MinnDevelopment merged commit cbad3b5 into development Dec 10, 2017
@MinnDevelopment MinnDevelopment deleted the feature/voice-events branch December 10, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants