Externalize opus binaries #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
status: in progress
|
@DV8FromTheWorld Could you give some comments on this? |
Moved back to 1.0.0
|
You could also allow people to use the opus distributions that come with their systems (eg. |
The path should be provided to OpusLibrary.loadFrom(String) before using the audio system. The method will return true if the provided path could be loaded as a library and false if it cannot or the system was already initialized.
MinnDevelopment
added
status: completed
| public static synchronized boolean loadFrom(String absolutePath) | ||
| { | ||
| if (initialized) | ||
| return false; |
There was a problem hiding this comment.
should this return audioSupported?
There was a problem hiding this comment.
ensureOpus() returns audioSupported because it is used by JDA to check whether the library is available or not. loadFrom() returns true if the library is loaded from that method invokation and false if not (it was already loaded).
if (AudioNatives.loadFrom("/lib/.../libopus.so")) {
log.info("Loaded custom library at /lib/.../libopus.so");
} else {
log.info("Opus binaries were already loaded, skipping.");
}Cleanup javadoc exclude path
Updated README to suggest excluding opus-java by default, the transitive JNA dependency makes a difference here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
There are several guidelines you should follow in order for your
Pull Request to be merged.
Description
This should make the artifact easier to exclude and allows for a much smaller dependency.
Additionally we could offer audio support without the opus binaries (like lavaplayer which already does the opus encoding).
PS:
We have to also publish the opus artifact to jcenter.https://bintray.com/minndevelopment/maven/opus-java