Additional invite info #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
status: documentation needed
| @@ -1260,8 +1261,11 @@ public Invite createInvite(JSONObject object) | |||
| final long guildId = guildObject.getLong("id"); | |||
| final String guildName = guildObject.getString("name"); | |||
| final String guildSplashId = guildObject.optString("splash", null); | |||
| final VerificationLevel guildVerificationLevel = VerificationLevel.fromKey(guildObject.optInt("verification_level", -1)); | |||
| final int presenceCount = object.optInt("approximate_presence_count", -1); | |||
| final int memberCount = object.optInt("approximate_member_count", -1); | |||
There was a problem hiding this comment.
Should this be in the guild object if discord doesn't provide them in the guild object?
There was a problem hiding this comment.
It's not provided in the guild object, but from a library user's standpoint I think it might make more sense. Either way would be fine from an implementation standpoint though.
There was a problem hiding this comment.
I'm fine with either, too
| @@ -23,6 +23,7 @@ | |||
|
|
|||
| import javax.annotation.CheckReturnValue; | |||
| import java.time.OffsetDateTime; | |||
| import net.dv8tion.jda.core.entities.Guild.VerificationLevel; | |||
MinnDevelopment
added
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
There are several guidelines you should follow in order for your
Pull Request to be merged.
Description
This PR fulfills #666 by adding an additional Invite.resolve method to allow getting counts and verification level from invites.
Still needed at this time: docs, possibly exceptions if the resolved invite is not one that contains counts.