Improve use of MDC #721
Merged
Improve use of MDC #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we use copies of the initial map in order to restore thread locality for MDC, in addition we now set MDC keys in the onThreadStart methods for websocket adapters
This comment has been minimized.
This comment has been minimized.
kantenkugel
reviewed
Jul 21, 2018
| { | ||
| return channel.getJDA(); | ||
| return (JDAImpl) channel.getJDA(); |
There was a problem hiding this comment.
Can't this be replaced with just return api;? (see line 91)
There was a problem hiding this comment.
No it can't be replaced with that, the api reference is local in the constructor.
MinnDevelopment
added
the
status: completed
# Conflicts: # src/main/java/net/dv8tion/jda/core/requests/RateLimiter.java # src/main/java/net/dv8tion/jda/core/requests/Requester.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
There are several guidelines you should follow in order for your
Pull Request to be merged.
Description
Now we use copies of the initial map in order to restore thread locality
for MDC, in addition we now set MDC keys in the onThreadStart methods
for websocket adapters