Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add South African server region #722

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Add South African server region #722

merged 2 commits into from
Jul 23, 2018

Conversation

ithinkimcats
Copy link
Contributor

Pull Request Etiquette

There are several guidelines you should follow in order for your
Pull Request to be merged.

It is sometimes better to include more changes in a single commit.
If you find yourself having an overwhelming amount of commits, you
can rebase your branch.

Description

Request adds new South African server region.

1474ec 1

add South Africa voice region
Copy link
Member

@MinnDevelopment MinnDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however we should probably consider to sort the constants in this enum by name 🤔

@MinnDevelopment MinnDevelopment added this to the Upcoming Release milestone Jul 22, 2018
Sort voice regions by name
@MinnDevelopment
Copy link
Member

Thank you, I was going to sort them myself but this makes it easier.

@MinnDevelopment MinnDevelopment merged commit 874e892 into discord-jda:development Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants