Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShardManager#getGuildById #761

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Fix ShardManager#getGuildById #761

merged 1 commit into from
Sep 4, 2018

Conversation

MinnDevelopment
Copy link
Member

Pull Request Etiquette

Description

Now shard manager properly returns shardsTotal and properly gets guilds (again).

@MinnDevelopment MinnDevelopment added this to the 3.8.0 milestone Sep 4, 2018
@MinnDevelopment MinnDevelopment added the status: completed has been completed but is not yet released label Sep 4, 2018
Almighty-Alpaca
Almighty-Alpaca approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@Almighty-Alpaca Almighty-Alpaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinnDevelopment MinnDevelopment merged commit 0d0069c into development Sep 4, 2018
@MinnDevelopment MinnDevelopment deleted the patch-shard-manager branch September 4, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Almighty-Alpaca Almighty-Alpaca Almighty-Alpaca approved these changes

Assignees
No one assigned
Labels
bug priority: high status: completed has been completed but is not yet released
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MinnDevelopment @Almighty-Alpaca