Make AudioWebSocket a subordinate class #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix issues with shard reconnects not stopping managers
MinnDevelopment
force-pushed
the
patch-audio-ws
branch
from
e0aab87
to
2826028
Compare
MinnDevelopment
changed the title
MinnDevelopment
added
the
status: completed
AudioConnection was actually testing this for null which would be an impossibility when we use Arrays.copyOf as it will throw instead
These looked so much like frankenstein's monster after all the work both dv8 and I put into it. So I cleaned it up a little for future readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Description
Now AudioWebSocket is a subclass of AudioConnection and they can freely share fields.