Fix granting / denying permissions #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PermissionOverride po = tc.createPermissionOverride(role).complete();
//wait
print(po.getAllowedRaw() + " " + po.getDeniedRaw());
po.getManager().grant(Permission.MESSAGE_ATTACH_FILES.getRawValue()).complete();
//wait
print(po.getAllowedRaw() + " " + po.getDeniedRaw());
po.getManager().deny(Permission.MESSAGE_ATTACH_FILES.getRawValue()).complete();
//wait
print(po.getAllowedRaw() + " " + po.getDeniedRaw());
po.getManager().grant(Permission.MESSAGE_ATTACH_FILES.getRawValue()).complete();
//wait
print(po.getAllowedRaw() + " " + po.getDeniedRaw());
po.getManager().clear(Permission.MESSAGE_ATTACH_FILES.getRawValue()).complete();
//wait
print(po.getAllowedRaw() + " " + po.getDeniedRaw());results in which looks correct to me. |
| { | ||
| this.allowed |= permissions; | ||
| this.set |= ALLOWED; | ||
| } |
There was a problem hiding this comment.
So what this code now does: if none of the granted permissions are currently granted we set them.
This is really not how this is supposed to go, we want to update if any of the permissions are newly granted.
My suggestion was to only change the this.set |= ALLOWED.
MinnDevelopment
added
bug
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #767, please see that issue for details.