added setPresence to ShardManager and improved documentation consistency #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/dv8tion/jda/bot/sharding/DefaultShardManager.java
Outdated
Show resolved
Hide resolved
Almighty-Alpaca
approved these changes
Nov 8, 2018
| @@ -930,11 +944,11 @@ default VoiceChannel getVoiceChannelById(final String id) | |||
| * | |||
| * <p>This will also change the game for shards that are created in the future. | |||
| * | |||
| * @param game | |||
There was a problem hiding this comment.
As far as I know, we always use 2 spaces after @param even if it isn't strictly necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This PR adds
ShardManager#setPresence(OnlineStatus, Game)andShardManager#setPresenceProvider(IntFunction<OnlineStatus>, IntFunction<Game>)for convenience to update both fields in a single method and status update. I also improved the documentation ofShardManagerto follow the Structure Guide.