Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow modifying the CategoryId for CategoryChannels #1282

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Commits on Mar 13, 2019

  1. Add NestedChannelProperties type

    This change fixes an issue that was introduced with the INestedChannel type. Previously, it was possible to use ModifyAsync on a ChannelCategory to set it's CategoryId. This is not supported, and would probably error.
    This is a breaking change, however I can't imagine that anyone was trying to nest categories before this. I don't think that it should affect anyone.
    
    This change adds the NestedChannelProperties and ModifyNestedChannelParams types, which follow the same class hierarchy as the public-facing channel entities. This allows only guild voice and text channels to be placed under a category.
    The change
    Chris-Johnston committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    b919a1e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2019

  1. docs: update CategoryId remarks for detaching a channel

    setting a categoryid to 0 will result in a bad request, null will actually detach
    Chris-Johnston committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    102aa0c View commit details
    Browse the repository at this point in the history