[WAIT TO MERGE] Sharding Capabilities #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'bot-api' of github.com:teamreflex/DiscordPHP: Revert "$data->id to $data->user->id on `GUILD_MEMBER_UPDATE`" $data->id to $data->user->id on `GUILD_MEMBER_UPDATE` Implemented chunking for `GUILD_CREATE` events properly Applied fixes from StyleCI Fixed up audio recieving Applied fixes from StyleCI Disabled chunking on `GUILD_CREATE` Added the option to provide a DNS resolver
Applied fixes from StyleCI
Applied fixes from StyleCI
|
👍 looks good! Only thing would be that would it be possible to provide the options to the WebSocket class instead of through the Discord client? |
|
Could you resend this in on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add sharding to DiscordPHP.
Wait to merge until discord/discord-api-docs#17 is implemented and released.