Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USE_EXTERNAL_APPS permission #6913

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

sklein12
Copy link
Contributor

@sklein12 sklein12 commented Jun 4, 2024

Adding USE_EXTERNAL_APPS permission to docs

@sklein12 sklein12 marked this pull request as ready for review June 4, 2024 22:39
@sklein12 sklein12 marked this pull request as draft June 4, 2024 22:39
@sklein12 sklein12 marked this pull request as ready for review June 4, 2024 22:39
@sklein12 sklein12 requested a review from shaydewael June 4, 2024 22:39
docs/topics/Permissions.md Outdated Show resolved Hide resolved
@randomairborne
Copy link

randomairborne commented Jun 5, 2024

Perhaps consider renaming this permission to DISPLAY_EXTERNAL_APPS or something similar, or make that clear in the final UI? Given that users can still of course use external apps. it seems that the permission that fully disables user apps is USE_APPLICATION_COMMANDS.

@@ -80,6 +80,7 @@ Below is a table of all current permissions, their integer values in hexadecimal
| USE_EXTERNAL_SOUNDS | `0x0000200000000000` `(1 << 45)` | Allows the usage of custom soundboard sounds from other servers | V |
| SEND_VOICE_MESSAGES | `0x0000400000000000` `(1 << 46)` | Allows sending voice messages | T, V, S |
| SEND_POLLS | `0x0002000000000000` `(1 << 49)` | Allows sending polls | T, V, S |
| USE_EXTERNAL_APPS | `0x0004000000000000` `(1 << 50)` | Allows using user installed apps not installed to the server. When disabled, users will still be allowed to use their apps but the responses will be ephemeral. | T, V, S |
Copy link
Contributor

@AlmostSuspense AlmostSuspense Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| USE_EXTERNAL_APPS | `0x0004000000000000` `(1 << 50)` | Allows using user installed apps not installed to the server. When disabled, users will still be allowed to use their apps but the responses will be ephemeral. | T, V, S |
| USE_EXTERNAL_APPS | `0x0004000000000000` `(1 << 50)` | Allows the use of user-installed apps that are not already installed to the server. When disabled, users will still be able to use them, but the responses will be forced ephemeral. | T, V, S |

@sklein12
Copy link
Contributor Author

sklein12 commented Jun 5, 2024

Perhaps consider renaming this permission to DISPLAY_EXTERNAL_APPS or something similar, or make that clear in the final UI? Given that users can still of course use external apps. it seems that the permission that fully disables user apps is USE_APPLICATION_COMMANDS.

The behavior is the same with both permissions. If either USE_APPLICATION_COMMANDS or USE_EXTERNAL_APPS is disabled, the user will still be able to use their apps but the responses will be forced ephemeral.

@randomairborne
Copy link

The behavior is not the same with both permissions. Go test it. USE_APPLICATION_COMMANDS disabling does disable use of user app interactions (both slash and context menu) in servers.

@sklein12
Copy link
Contributor Author

sklein12 commented Jun 5, 2024

The behavior is not the same with both permissions. Go test it. USE_APPLICATION_COMMANDS disabling does disable use of user app interactions (both slash and context menu) in servers.

This is not the intended behavior and is being changed. You will still be able to use your user installed apps even with that disabled.

@sklein12 sklein12 requested a review from colinloretz June 5, 2024 22:23
vilgotf pushed a commit to twilight-rs/twilight that referenced this pull request Jun 15, 2024
@bsian03 bsian03 mentioned this pull request Oct 19, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants