Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RESTAPIAttachment): add more properties #1073

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(RESTAPIAttachment): add more properties #1073

merged 1 commit into from
Aug 23, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 23, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

The documentation isn't clear about what fields can be sent when creating messages, so I checked the spec and added the missing fields

https://github.com/discord/discord-api-spec/blob/f31843808734a58e4c351fba6fd5768bb480b066/specs/openapi.json#L22778-L22831

Ignored is_remix since that field isn't documented at all

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@almeidx almeidx requested review from a team as code owners August 23, 2024 08:59
@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 9:28am

@almeidx almeidx force-pushed the feat/rest-api-attachment-props branch from fdb4ba4 to f7fad86 Compare August 23, 2024 09:05
@almeidx almeidx force-pushed the feat/rest-api-attachment-props branch from f7fad86 to c3c3e38 Compare August 23, 2024 09:07
@vladfrangu vladfrangu merged commit f019f0f into main Aug 23, 2024
7 of 8 checks passed
@vladfrangu vladfrangu deleted the feat/rest-api-attachment-props branch August 23, 2024 09:09
@0xhaaaash 0xhaaaash mentioned this pull request Sep 17, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 17, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Sep 17, 2024
Open
@theKerosen theKerosen mentioned this pull request Sep 17, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 19, 2024
Open
@VicDario VicDario mentioned this pull request Sep 20, 2024
Closed
@whizbangpop whizbangpop mentioned this pull request Sep 21, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 21, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Sep 22, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 24, 2024
Open
@theKerosen theKerosen mentioned this pull request Sep 24, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 27, 2024
Open
@theKerosen theKerosen mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
topic:payloads topic:rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almeidx @vladfrangu