Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct types for APIAuditLogChangeKey$Add and APIAuditLogChangeKey$Remove #955

Merged
merged 5 commits into from
Jun 2, 2024
Merged

fix: Correct types for APIAuditLogChangeKey$Add and APIAuditLogChangeKey$Remove #955

merged 5 commits into from
Jun 2, 2024

Conversation

cobaltt7
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

new_value is an array of objects that contain the role id and name

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

https://canary.discord.com/developers/docs/resources/audit-log#audit-log-change-object-audit-log-change-exceptions:~:text=as%20keys-,new_value,name,-Webhook

@cobaltt7 cobaltt7 requested review from a team as code owners April 16, 2024 23:50
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 1:16pm

vladfrangu
vladfrangu previously requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to lint the code!

@almeidx almeidx requested a review from vladfrangu June 2, 2024 13:02
@vladfrangu vladfrangu merged commit f859a96 into discordjs:main Jun 2, 2024
6 checks passed
@cobaltt7 cobaltt7 deleted the patch-1 branch June 2, 2024 18:42
@SkyDev125 SkyDev125 mentioned this pull request Jun 25, 2024
Closed
@theKerosen theKerosen mentioned this pull request Jun 25, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Jun 26, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jul 2, 2024
Closed
@0xhaaaash 0xhaaaash mentioned this pull request Jul 2, 2024
Open
@theKerosen theKerosen mentioned this pull request Jul 2, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jul 5, 2024
Closed
@0xhaaaash 0xhaaaash mentioned this pull request Jul 5, 2024
Open
@theKerosen theKerosen mentioned this pull request Jul 5, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jul 10, 2024
Closed
@theKerosen theKerosen mentioned this pull request Jul 10, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Jul 11, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jul 19, 2024
Closed
@0xhaaaash 0xhaaaash mentioned this pull request Jul 19, 2024
Open
@theKerosen theKerosen mentioned this pull request Jul 19, 2024
Open
@mezotv mezotv mentioned this pull request Jul 22, 2024
Closed
@Pxntricia Pxntricia mentioned this pull request Jul 25, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jul 26, 2024
Merged
@0xhaaaash 0xhaaaash mentioned this pull request Jul 26, 2024
Open
@theKerosen theKerosen mentioned this pull request Jul 26, 2024
Open
@MAPXOR12 MAPXOR12 mentioned this pull request Aug 13, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Aug 13, 2024
Merged
@0xhaaaash 0xhaaaash mentioned this pull request Aug 13, 2024
Open
@theKerosen theKerosen mentioned this pull request Aug 13, 2024
Open
@SpazElectro SpazElectro mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
topic:payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cobaltt7 @vladfrangu @almeidx