Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): show union members of type aliases #10001

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Nov 26, 2023

Please describe the changes this PR makes and why it should be merged:

Adds a Union Members section on Type Alias documentation pages that references the different types the Type Alias is a union of. This section only shows if the Type Alias is a union.

Also refactored some types in mainlib typings to interfaces for better documentation purposes.

Removed the unused RecursiveArray type, which was identical to the RecursiveReadonlyArray type but never used.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 1:15am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 1:15am

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (cbbbfb9) 58.79% compared to head (dcd6533) 58.49%.
Report is 1 commits behind head on main.

Files Patch % Lines
apps/website/src/components/model/TypeAlias.tsx 0.00% 51 Missing ⚠️
...ents/documentation/section/UnionMembersSection.tsx 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10001      +/-   ##
==========================================
- Coverage   58.79%   58.49%   -0.30%     
==========================================
  Files         240      241       +1     
  Lines       17033    17118      +85     
  Branches     1240     1241       +1     
==========================================
  Hits        10014    10014              
- Misses       6974     7059      +85     
  Partials       45       45              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants