-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(formatters): Add support for object and name param in formatEmoji()
#10076
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
There's some formatting and linting issues, could you please fix them? And it'd be nice if you added tests for the changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10076 +/- ##
==========================================
+ Coverage 58.36% 58.51% +0.15%
==========================================
Files 242 242
Lines 17184 17248 +64
Branches 1243 1246 +3
==========================================
+ Hits 10029 10093 +64
Misses 7110 7110
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emojiId is a required parameter, so no need to pass it in options I would do: formatEmoji(emojiId: Snowflake, animatedOrOptions?: boolean | { name?: string, animated?: boolean } ) and animated parameter is deprecated as we recommend to use options |
Just needs more overloads as Jiralite said here, other than that, looks good |
Please describe the changes this PR makes and why it should be merged:
formatEmoji()
emojiId
,animated
parametersStatus and versioning classification: