-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove usage of mixin on error classes #10128
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Why did the constructor become private on the typings? A private constructor would imply some other way of creating the object, via some static method, but the internal code still creates it via Ex. match(error)
.with(
P.instanceOf(DiscordjsError),
({ code }) => code === DiscordjsErrorCodes.InteractionCollectorError,
() => { /* some handler code */ }
) now breaks with
|
Please describe the changes this PR makes and why it should be merged:
Removed the internal mixin function
DiscordjsErrorMixin
in order to provide better documentationhttps://discord.js.org/docs/packages/discord.js/14.14.1/DiscordjsError:Class
Status and versioning classification: